This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
fix: updating the oas package to pull in some fixes for handling response schemas #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafegoldberg
approved these changes
Jan 28, 2020
rafegoldberg
approved these changes
Jan 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the oas package to do a few things:
ResponseSchemaBodyout of that and into theoaspackage.$ref, that didn't have an explicittypeproperty set, we wouldn't include it in the flattened output.This PR doesn't add any unit tests because those tests have been added in the oas package instead. See readmeio/oas#104 for the PR that has this code migration, bug fix, and unit tests.
That said, here is a screenshot of the schema bug in action:
And with the fix:
See https://github.com/readmeio/oas/pull/104/files#diff-50da53e033459b1db3c580ac63f65edfR73-R88 for the full test case.